Commit 8558aef4 authored by Zilin Guan's avatar Zilin Guan Committed by Jakub Kicinski
Browse files

net: liquidio: Fix off-by-one error in PF setup_nic_devices() cleanup 



In setup_nic_devices(), the initialization loop jumps to the label
setup_nic_dev_free on failure. The current cleanup loop while(i--)
skip the failing index i, causing a memory leak.

Fix this by changing the loop to iterate from the current index i
down to 0.

Also, decrement i in the devlink_alloc failure path to point to the
last successfully allocated index.

Compile tested only. Issue found using code review.

Fixes: f21fb3ed ("Add support of Cavium Liquidio ethernet adapters")
Suggested-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarZilin Guan <zilin@seu.edu.cn>
Reviewed-by: default avatarKory Maincent <kory.maincent@bootlin.com>
Link: https://patch.msgid.link/20260128154440.278369-3-zilin@seu.edu.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 926ede0c

drivers/net/ethernet/cavium/liquidio/lio_main.c

+3 −2
Original line number Diff line number Diff line
@@ -3750,6 +3750,7 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) 
	if (!devlink) {

		device_unlock(&octeon_dev->pci_dev->dev);

		dev_err(&octeon_dev->pci_dev->dev, "devlink alloc failed\n");

		i--;

		goto setup_nic_dev_free;

	}
@@ -3765,11 +3766,11 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) 


setup_nic_dev_free:



	while (i--) {

	do {

		dev_err(&octeon_dev->pci_dev->dev,

			"NIC ifidx:%d Setup failed\n", i);

		liquidio_destroy_nic_device(octeon_dev, i);

	}

	} while (i--);



setup_nic_dev_done: