Commit 856caabf authored Jun 06, 2023 by Leo Yan Committed by Arnaldo Carvalho de Melo Aug 16, 2023

perf parse-regs: Remove PERF_REGS_{MAX|MASK} from common code



The macros PERF_REGS_MAX and PERF_REGS_MASK are architecture specific,
let's remove them from the common file util/perf_regs.c.

As a side effect, the weak functions arch__intr_reg_mask() and
arch__user_reg_mask() just return zeros, every arch defines its own
functions in the 'arch' folder for returning right values.

Note, we don't need to return intr/user register masks dynamically, this
is because these two functions are invoked during recording phase but
not decoding phase, they are always invoked on the native environment,
thus we don't need to parse them dynamically.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Eric Lin <eric.lin@sifive.com>
Cc: Fangrui Song <maskray@google.com>
Cc: Guo Ren <guoren@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Ivan Babrou <ivan@cloudflare.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Ming Wang <wangming01@loongson.cn>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-csky@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
Link: https://lore.kernel.org/r/20230606014559.21783-6-leo.yan@linaro.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 6a87e0f0

tools/perf/arch/arm/util/perf_regs.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -4,3 +4,13 @@
		const struct sample_reg sample_reg_masks[] = {
		SMPL_REG_END
		};

		uint64_t arch__intr_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

		uint64_t arch__user_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

tools/perf/arch/arm64/util/perf_regs.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -139,6 +139,11 @@ int arch_sdt_arg_parse_op(char old_op, char *new_op)
		return SDT_ARG_VALID;
		}

		uint64_t arch__intr_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

		uint64_t arch__user_reg_mask(void)
		{
		struct perf_event_attr attr = {

tools/perf/arch/csky/util/perf_regs.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -4,3 +4,13 @@
		const struct sample_reg sample_reg_masks[] = {
		SMPL_REG_END
		};

		uint64_t arch__intr_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

		uint64_t arch__user_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

tools/perf/arch/loongarch/util/perf_regs.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -4,3 +4,13 @@
		const struct sample_reg sample_reg_masks[] = {
		SMPL_REG_END
		};

		uint64_t arch__intr_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

		uint64_t arch__user_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

tools/perf/arch/mips/util/perf_regs.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -4,3 +4,13 @@
		const struct sample_reg sample_reg_masks[] = {
		SMPL_REG_END
		};

		uint64_t arch__intr_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}

		uint64_t arch__user_reg_mask(void)
		{
		return PERF_REGS_MASK;
		}