Commit 8573756b authored by Leo Yan's avatar Leo Yan Committed by Suzuki K Poulose
Browse files

coresight: Do not mix success path with failure handling 



Separate the failure handling path from the successful case.  Use the
'out_unlock' label only for failure handling.

Reviewed-by: default avatarJames Clark <james.clark@linaro.org>
Signed-off-by: default avatarLeo Yan <leo.yan@arm.com>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20260209-arm_coresight_refactor_dev_register-v4-7-62d6042f76f7@arm.com
parent 6b1ffc54

drivers/hwtracing/coresight/coresight-core.c

+13 −8
Original line number Diff line number Diff line
@@ -1398,17 +1398,22 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) 
	registered = true;



	ret = coresight_create_conns_sysfs_group(csdev);

	if (!ret)

	if (ret)

		goto out_unlock;



	ret = coresight_fixup_orphan_conns(csdev);

	if (ret)

		goto out_unlock;



out_unlock:

	mutex_unlock(&coresight_mutex);

	/* Success */

	if (!ret) {



	if (cti_assoc_ops && cti_assoc_ops->add)

		cti_assoc_ops->add(csdev);



	return csdev;

	}



out_unlock:

	mutex_unlock(&coresight_mutex);



	/* Unregister the device if needed */

	if (registered) {