Commit 857ae055 authored by Michal Luczaj's avatar Michal Luczaj Committed by Paolo Abeni
Browse files

vsock/bpf: Warn on socket without transport 



In the spirit of commit 91751e24 ("vsock: prevent null-ptr-deref in
vsock_*[has_data|has_space]"), armorize the "impossible" cases with a
warning.

Fixes: 634f1a71 ("vsock: support sockmap")
Signed-off-by: default avatarMichal Luczaj <mhal@rbox.co>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 8fb5bb16

net/vmw_vsock/af_vsock.c

+3 −0
Original line number Diff line number Diff line
@@ -1189,6 +1189,9 @@ static int vsock_read_skb(struct sock *sk, skb_read_actor_t read_actor) 
{

	struct vsock_sock *vsk = vsock_sk(sk);



	if (WARN_ON_ONCE(!vsk->transport))

		return -ENODEV;



	return vsk->transport->read_skb(vsk, read_actor);

}

net/vmw_vsock/vsock_bpf.c

+1 −1
Original line number Diff line number Diff line
@@ -87,7 +87,7 @@ static int vsock_bpf_recvmsg(struct sock *sk, struct msghdr *msg, 
	lock_sock(sk);

	vsk = vsock_sk(sk);



	if (!vsk->transport) {

	if (WARN_ON_ONCE(!vsk->transport)) {

		copied = -ENODEV;

		goto out;

	}