Commit 8589e325 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/manage: Rework irq_set_irq_wake() 



Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

No functional change.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/87ldrhq0hc.ffs@tglx
parent bddd10c5

kernel/irq/manage.c

+30 −35
Original line number Diff line number Diff line
@@ -846,20 +846,16 @@ static int set_irq_wake_real(unsigned int irq, unsigned int on) 
 */

int irq_set_irq_wake(unsigned int irq, unsigned int on)

{

	unsigned long flags;

	struct irq_desc *desc = irq_get_desc_buslock(irq, &flags, IRQ_GET_DESC_CHECK_GLOBAL);

	scoped_irqdesc_get_and_lock(irq, IRQ_GET_DESC_CHECK_GLOBAL) {

		struct irq_desc *desc = scoped_irqdesc;

		int ret = 0;



	if (!desc)

		return -EINVAL;



		/* Don't use NMIs as wake up interrupts please */

	if (irq_is_nmi(desc)) {

		ret = -EINVAL;

		goto out_unlock;

	}

		if (irq_is_nmi(desc))

			return -EINVAL;



	/* wakeup-capable irqs can be shared between drivers that

		/*

		 * wakeup-capable irqs can be shared between drivers that

		 * don't need to have the same sleep mode behaviors.

		 */

		if (on) {
@@ -881,11 +877,10 @@ int irq_set_irq_wake(unsigned int irq, unsigned int on) 
					irqd_clear(&desc->irq_data, IRQD_WAKEUP_STATE);

			}

		}



out_unlock:

	irq_put_desc_busunlock(desc, flags);

		return ret;

	}

	return -EINVAL;

}

EXPORT_SYMBOL(irq_set_irq_wake);



/*