Commit 859abe3f authored by Markus Elfring's avatar Markus Elfring Committed by Jakub Kicinski
Browse files

tipc: Reduce scope for the variable “fdefq” in tipc_link_tnl_prepare() 



The address of a data structure member was determined before
a corresponding null pointer check in the implementation of
the function “tipc_link_tnl_prepare”.

Thus avoid the risk for undefined behaviour by moving the definition
for the local variable “fdefq” into an if branch at the end.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/08fe8fc3-19c3-4324-8719-0ee74b0f32c9@web.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ea434273

net/tipc/link.c

+2 −1
Original line number Diff line number Diff line
@@ -1951,7 +1951,6 @@ void tipc_link_create_dummy_tnl_msg(struct tipc_link *l, 
void tipc_link_tnl_prepare(struct tipc_link *l, struct tipc_link *tnl,

			   int mtyp, struct sk_buff_head *xmitq)

{

	struct sk_buff_head *fdefq = &tnl->failover_deferdq;

	struct sk_buff *skb, *tnlskb;

	struct tipc_msg *hdr, tnlhdr;

	struct sk_buff_head *queue = &l->transmq;
@@ -2078,6 +2077,8 @@ void tipc_link_tnl_prepare(struct tipc_link *l, struct tipc_link *tnl, 
	tipc_link_xmit(tnl, &tnlq, xmitq);



	if (mtyp == FAILOVER_MSG) {

		struct sk_buff_head *fdefq = &tnl->failover_deferdq;



		tnl->drop_point = l->rcv_nxt;

		tnl->failover_reasm_skb = l->reasm_buf;

		l->reasm_buf = NULL;