Commit 85f72925 authored by Anuj Gupta's avatar Anuj Gupta Committed by Jens Axboe
Browse files

block: Correctly initialize BLK_INTEGRITY_NOGENERATE and BLK_INTEGRITY_NOVERIFY 



Currently, BLK_INTEGRITY_NOGENERATE and BLK_INTEGRITY_NOVERIFY are not
explicitly set during integrity initialization. This can lead to
incorrect reporting of read_verify and write_generate sysfs values,
particularly when a device does not support integrity. Ensure that these
flags are correctly initialized by default.

Reported-by: default avatarM Nikhil <nikh1092@linux.ibm.com>
Link: https://lore.kernel.org/linux-block/f6130475-3ccd-45d2-abde-3ccceada0f0a@linux.ibm.com/


Fixes: 9f4aa46f ("block: invert the BLK_INTEGRITY_{GENERATE,VERIFY} flags")
Signed-off-by: default avatarAnuj Gupta <anuj20.g@samsung.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250305063033.1813-3-anuj20.g@samsung.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 677e332e

block/blk-settings.c

+1 −0
Original line number Diff line number Diff line
@@ -114,6 +114,7 @@ static int blk_validate_integrity_limits(struct queue_limits *lim) 
			pr_warn("invalid PI settings.\n");

			return -EINVAL;

		}

		bi->flags |= BLK_INTEGRITY_NOGENERATE | BLK_INTEGRITY_NOVERIFY;

		return 0;

	}