Unverified Commit 86362293 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Krzysztof Wilczyński
Browse files

PCI: endpoint: Make struct pci_epf_ops in pci_epf_driver const 

The pci_epf_ops struct contains a set of callbacks that are used by the
pci_epf_driver, and is never modified by the EPF core itself.

Marking the struct pointer const allows EPF drivers to declare their
pci_epf_ops struct to be const.

This allows the struct to be placed in the read-only section. Which
for example brings some security benefits as the callbacks can not be
overwritten.

[kwilczynski: commit log]
Link: https://lore.kernel.org/linux-pci/20230722230848.589428-1-lars@metafoo.de


Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
parent b85ea95d

include/linux/pci-epf.h

+1 −1
Original line number Diff line number Diff line
@@ -98,7 +98,7 @@ struct pci_epf_driver { 
	void	(*remove)(struct pci_epf *epf);



	struct device_driver	driver;

	struct pci_epf_ops	*ops;

	const struct pci_epf_ops *ops;

	struct module		*owner;

	struct list_head	epf_group;

	const struct pci_epf_device_id	*id_table;