Unverified Commit 868adf8a authored by Gwendal Grignou's avatar Gwendal Grignou Committed by Ilpo Järvinen
Browse files

platform/x86: intel-vbtn: Use acpi_has_method to check for switch 



The check for a device having virtual buttons is done using
acpi_has_method(..."VBDL"). Mimic that for checking virtual switch
presence.

Signed-off-by: default avatarGwendal Grignou <gwendal@chromium.org>
Reviewed-by: default avatarKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240329143206.2977734-2-gwendal@chromium.org


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 0dd50b3e

drivers/platform/x86/intel/vbtn.c

+1 −5
Original line number Diff line number Diff line
@@ -258,9 +258,6 @@ static const struct dmi_system_id dmi_switches_allow_list[] = { 


static bool intel_vbtn_has_switches(acpi_handle handle, bool dual_accel)

{

	unsigned long long vgbs;

	acpi_status status;



	/* See dual_accel_detect.h for more info */

	if (dual_accel)

		return false;
@@ -268,8 +265,7 @@ static bool intel_vbtn_has_switches(acpi_handle handle, bool dual_accel) 
	if (!dmi_check_system(dmi_switches_allow_list))

		return false;



	status = acpi_evaluate_integer(handle, "VGBS", NULL, &vgbs);

	return ACPI_SUCCESS(status);

	return acpi_has_method(handle, "VGBS");

}



static int intel_vbtn_probe(struct platform_device *device)