Commit 86b04e4d authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Krzysztof Kozlowski
Browse files

w1: ds2431: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241211-sysfs-const-bin_attr-w1-v1-6-c4befd2aa7cc@weissschuh.net


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent be0d277f

drivers/w1/slaves/w1_ds2431.c

+5 −5
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ static int w1_f2d_readblock(struct w1_slave *sl, int off, int count, char *buf) 
}



static ssize_t eeprom_read(struct file *filp, struct kobject *kobj,

			   struct bin_attribute *bin_attr, char *buf,

			   const struct bin_attribute *bin_attr, char *buf,

			   loff_t off, size_t count)

{

	struct w1_slave *sl = kobj_to_w1_slave(kobj);
@@ -201,7 +201,7 @@ static int w1_f2d_write(struct w1_slave *sl, int addr, int len, const u8 *data) 
}



static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,

			    struct bin_attribute *bin_attr, char *buf,

			    const struct bin_attribute *bin_attr, char *buf,

			    loff_t off, size_t count)

{

	struct w1_slave *sl = kobj_to_w1_slave(kobj);
@@ -262,15 +262,15 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj, 
	return count;

}



static BIN_ATTR_RW(eeprom, W1_F2D_EEPROM_SIZE);

static const BIN_ATTR_RW(eeprom, W1_F2D_EEPROM_SIZE);



static struct bin_attribute *w1_f2d_bin_attrs[] = {

static const struct bin_attribute *const w1_f2d_bin_attrs[] = {

	&bin_attr_eeprom,

	NULL,

};



static const struct attribute_group w1_f2d_group = {

	.bin_attrs = w1_f2d_bin_attrs,

	.bin_attrs_new = w1_f2d_bin_attrs,

};



static const struct attribute_group *w1_f2d_groups[] = {