Unverified Commit 86dd725b authored by Herve Codina's avatar Herve Codina Committed by Mark Brown
Browse files

ASoC: fsl: fsl_qmc_audio: Fix issues detected by checkpatch 



./scripts/checkpatch.pl --strict --codespell detected several issues
when running on the fsl_qmc_audio.c file:
  - CHECK: spaces preferred around that '*' (ctx:VxV)
  - CHECK: Alignment should match open parenthesis
  - CHECK: Comparison to NULL could be written "!prtd"
  - CHECK: spaces preferred around that '/' (ctx:VxV)
  - CHECK: Lines should not end with a '('
  - CHECK: Please don't use multiple blank lines
Some of them are present several times.

Fix all of these issues without any functional changes.

Signed-off-by: default avatarHerve Codina <herve.codina@bootlin.com>
Link: https://patch.msgid.link/20240701113038.55144-3-herve.codina@bootlin.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e6259990

sound/soc/fsl/fsl_qmc_audio.c

+31 −34
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ static int qmc_audio_pcm_open(struct snd_soc_component *component, 
		return ret;



	prtd = kzalloc(sizeof(*prtd), GFP_KERNEL);

	if (prtd == NULL)

	if (!prtd)

		return -ENOMEM;



	runtime->private_data = prtd;
@@ -356,8 +356,7 @@ static int qmc_dai_hw_rule_playback_channels_by_format(struct snd_pcm_hw_params 
	return qmc_dai_hw_rule_channels_by_format(qmc_dai, params, qmc_dai->nb_tx_ts);

}



static int qmc_dai_hw_rule_capture_channels_by_format(

			struct snd_pcm_hw_params *params,

static int qmc_dai_hw_rule_capture_channels_by_format(struct snd_pcm_hw_params *params,

						      struct snd_pcm_hw_rule *rule)

{

	struct qmc_dai *qmc_dai = rule->private;
@@ -394,8 +393,7 @@ static int qmc_dai_hw_rule_format_by_channels(struct qmc_dai *qmc_dai, 
	return snd_mask_refine(f_old, &f_new);

}



static int qmc_dai_hw_rule_playback_format_by_channels(

			struct snd_pcm_hw_params *params,

static int qmc_dai_hw_rule_playback_format_by_channels(struct snd_pcm_hw_params *params,

						       struct snd_pcm_hw_rule *rule)

{

	struct qmc_dai *qmc_dai = rule->private;
@@ -403,8 +401,7 @@ static int qmc_dai_hw_rule_playback_format_by_channels( 
	return qmc_dai_hw_rule_format_by_channels(qmc_dai, params, qmc_dai->nb_tx_ts);

}



static int qmc_dai_hw_rule_capture_format_by_channels(

			struct snd_pcm_hw_params *params,

static int qmc_dai_hw_rule_capture_format_by_channels(struct snd_pcm_hw_params *params,

						      struct snd_pcm_hw_rule *rule)

{

	struct qmc_dai *qmc_dai = rule->private;
@@ -587,7 +584,8 @@ static u64 qmc_audio_formats(u8 nb_ts) 
}



static int qmc_audio_dai_parse(struct qmc_audio *qmc_audio, struct device_node *np,

	struct qmc_dai *qmc_dai, struct snd_soc_dai_driver *qmc_soc_dai_driver)

			       struct qmc_dai *qmc_dai,

			       struct snd_soc_dai_driver *qmc_soc_dai_driver)

{

	struct qmc_chan_info info;

	u32 val;
@@ -704,7 +702,6 @@ static int qmc_audio_probe(struct platform_device *pdev) 
		i++;

	}





	platform_set_drvdata(pdev, qmc_audio);



	ret = devm_snd_soc_register_component(qmc_audio->dev,