Commit 86de8484 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Chandan Babu R
Browse files

xfs: remove a racy if_bytes check in xfs_reflink_end_cow_extent 



Accessing if_bytes without the ilock is racy.  Remove the initial
if_bytes == 0 check in xfs_reflink_end_cow_extent and let
ext_iext_lookup_extent fail for this case after we've taken the ilock.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatar"Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: default avatarChandan Babu R <chandanbabu@kernel.org>
parent 99fb6b7a

fs/xfs/xfs_reflink.c

+0 −6
Original line number Diff line number Diff line
@@ -712,12 +712,6 @@ xfs_reflink_end_cow_extent( 
	int			nmaps;

	int			error;



	/* No COW extents?  That's easy! */

	if (ifp->if_bytes == 0) {

		*offset_fsb = end_fsb;

		return 0;

	}



	resblks = XFS_EXTENTADD_SPACE_RES(mp, XFS_DATA_FORK);

	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_write, resblks, 0,

			XFS_TRANS_RESERVE, &tp);