Commit 86df36b9 authored by Tim Huang's avatar Tim Huang Committed by Alex Deucher
Browse files

drm/amd/pm: fix uninitialized variable warning for smu8_hwmgr 



Clear warnings that using uninitialized value level when fails
to get the value from SMU.

Signed-off-by: default avatarTim Huang <Tim.Huang@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent cfec96c1

drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu8_hwmgr.c

+12 −3
Original line number Diff line number Diff line
@@ -584,6 +584,7 @@ static int smu8_init_uvd_limit(struct pp_hwmgr *hwmgr) 
				hwmgr->dyn_state.uvd_clock_voltage_dependency_table;

	unsigned long clock = 0;

	uint32_t level;

	int ret;



	if (NULL == table || table->count <= 0)

		return -EINVAL;
@@ -591,7 +592,9 @@ static int smu8_init_uvd_limit(struct pp_hwmgr *hwmgr) 
	data->uvd_dpm.soft_min_clk = 0;

	data->uvd_dpm.hard_min_clk = 0;



	smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxUvdLevel, &level);

	ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxUvdLevel, &level);

	if (ret)

		return ret;



	if (level < table->count)

		clock = table->entries[level].vclk;
@@ -611,6 +614,7 @@ static int smu8_init_vce_limit(struct pp_hwmgr *hwmgr) 
				hwmgr->dyn_state.vce_clock_voltage_dependency_table;

	unsigned long clock = 0;

	uint32_t level;

	int ret;



	if (NULL == table || table->count <= 0)

		return -EINVAL;
@@ -618,7 +622,9 @@ static int smu8_init_vce_limit(struct pp_hwmgr *hwmgr) 
	data->vce_dpm.soft_min_clk = 0;

	data->vce_dpm.hard_min_clk = 0;



	smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxEclkLevel, &level);

	ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxEclkLevel, &level);

	if (ret)

		return ret;



	if (level < table->count)

		clock = table->entries[level].ecclk;
@@ -638,6 +644,7 @@ static int smu8_init_acp_limit(struct pp_hwmgr *hwmgr) 
				hwmgr->dyn_state.acp_clock_voltage_dependency_table;

	unsigned long clock = 0;

	uint32_t level;

	int ret;



	if (NULL == table || table->count <= 0)

		return -EINVAL;
@@ -645,7 +652,9 @@ static int smu8_init_acp_limit(struct pp_hwmgr *hwmgr) 
	data->acp_dpm.soft_min_clk = 0;

	data->acp_dpm.hard_min_clk = 0;



	smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxAclkLevel, &level);

	ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxAclkLevel, &level);

	if (ret)

		return ret;



	if (level < table->count)

		clock = table->entries[level].acpclk;