Commit 8748368c authored by Takashi Sakamoto's avatar Takashi Sakamoto
Browse files

firewire: ohci: remove obsolete module-level debug parameter 

The module-level debug parameter was added in v2.6.26 by a commit
ad3c0fe8 ("firewire: debug interrupt events"). Its functionality
has long been superseded by tracepoints.

This commit removes the module parameter, bye.

Link: https://lore.kernel.org/r/20250821003017.186752-5-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
parent 6354cc95

drivers/firewire/ohci.c

+0 −10
Original line number Diff line number Diff line
@@ -393,11 +393,6 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default = 0" 
	", IR wake unreliable = "	__stringify(QUIRK_IR_WAKE)

	")");



static int param_debug;

module_param_named(debug, param_debug, int, 0644);

MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or later. (default = 0"

	", or a combination, or all = -1)");



static bool param_remote_dma;

module_param_named(remote_dma, param_remote_dma, bool, 0444);

MODULE_PARM_DESC(remote_dma, "Enable unfiltered remote DMA (default = N)");
@@ -2017,11 +2012,6 @@ static irqreturn_t irq_handler(int irq, void *data) 
	if (!event || !~event)

		return IRQ_NONE;



	if (unlikely(param_debug > 0)) {

		dev_notice_ratelimited(ohci->card.device,

				       "The debug parameter is superseded by tracepoints events, and deprecated.");

	}



	/*

	 * busReset and postedWriteErr events must not be cleared yet

	 * (OHCI 1.1 clauses 7.2.3.2 and 13.2.8.1)