Unverified Commit 87997b6c authored by Michał Winiarski's avatar Michał Winiarski Committed by Rodrigo Vivi
Browse files

drm/xe/pf: Fix use-after-free in migration restore 



When an error is returned from xe_sriov_pf_migration_restore_produce(),
the data pointer is not set to NULL, which can trigger use-after-free
in subsequent .write() calls.
Set the pointer to NULL upon error to fix the problem.

Fixes: 1ed30397 ("drm/xe/pf: Add support for encap/decap of bitstream to/from packet")
Reported-by: default avatarSebastian Österlund <sebastian.osterlund@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/7230


Reviewed-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
Link: https://patch.msgid.link/20260217154118.176902-1-michal.winiarski@intel.com


Signed-off-by: default avatarMichał Winiarski <michal.winiarski@intel.com>
(cherry picked from commit 4f53d8c6)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent c3692998

drivers/gpu/drm/xe/xe_sriov_packet.c

+2 −0
Original line number Diff line number Diff line
@@ -341,6 +341,8 @@ ssize_t xe_sriov_packet_write_single(struct xe_device *xe, unsigned int vfid, 
		ret = xe_sriov_pf_migration_restore_produce(xe, vfid, *data);

		if (ret) {

			xe_sriov_packet_free(*data);

			*data = NULL;



			return ret;

		}