Commit 87b4d8d2 authored by Kashyap Desai's avatar Kashyap Desai Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Fix incorrect dereference of srq in async event 

Currently driver is not getting correct srq. Dereference only if qplib has
a valid srq.

Fixes: b02fd3f7 ("RDMA/bnxt_re: Report async events and errors")
Link: https://patch.msgid.link/r/1728373302-19530-4-git-send-email-selvin.xavier@broadcom.com


Reviewed-by: default avatarSaravanan Vajravel <saravanan.vajravel@broadcom.com>
Reviewed-by: default avatarChandramohan Akula <chandramohan.akula@broadcom.com>
Signed-off-by: default avatarKashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent a9e6e744

drivers/infiniband/hw/bnxt_re/main.c

+5 −2
Original line number Diff line number Diff line
@@ -1028,12 +1028,15 @@ static int bnxt_re_handle_unaffi_async_event(struct creq_func_event 
static int bnxt_re_handle_qp_async_event(struct creq_qp_event *qp_event,

					 struct bnxt_re_qp *qp)

{

	struct bnxt_re_srq *srq = container_of(qp->qplib_qp.srq, struct bnxt_re_srq,

					       qplib_srq);

	struct creq_qp_error_notification *err_event;

	struct bnxt_re_srq *srq = NULL;

	struct ib_event event = {};

	unsigned int flags;



	if (qp->qplib_qp.srq)

		srq =  container_of(qp->qplib_qp.srq, struct bnxt_re_srq,

				    qplib_srq);



	if (qp->qplib_qp.state == CMDQ_MODIFY_QP_NEW_STATE_ERR &&

	    rdma_is_kernel_res(&qp->ib_qp.res)) {

		flags = bnxt_re_lock_cqs(qp);