Commit 87d4fbf4 authored by Shivank Garg's avatar Shivank Garg Committed by Sean Christopherson
Browse files

KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation 



Remove the redundant kvm_gmem_getattr() implementation that simply calls
generic_fillattr() without any special handling. The VFS layer
(vfs_getattr_nosec()) will call generic_fillattr() by default when no
custom getattr operation is provided in the inode_operations structure.

This is a cleanup with no functional change.

Signed-off-by: default avatarShivank Garg <shivankg@amd.com>
Reviewed-By: default avatarAckerley Tng <ackerleytng@google.com>
Reviewed-by: default avatarPankaj Gupta <pankaj.gupta@amd.com>
Link: https://lore.kernel.org/r/20250602172317.10601-1-shivankg@amd.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent aa006b2e

virt/kvm/guest_memfd.c

+0 −11
Original line number Diff line number Diff line
@@ -382,23 +382,12 @@ static const struct address_space_operations kvm_gmem_aops = { 
#endif

};



static int kvm_gmem_getattr(struct mnt_idmap *idmap, const struct path *path,

			    struct kstat *stat, u32 request_mask,

			    unsigned int query_flags)

{

	struct inode *inode = path->dentry->d_inode;



	generic_fillattr(idmap, request_mask, inode, stat);

	return 0;

}



static int kvm_gmem_setattr(struct mnt_idmap *idmap, struct dentry *dentry,

			    struct iattr *attr)

{

	return -EINVAL;

}

static const struct inode_operations kvm_gmem_iops = {

	.getattr	= kvm_gmem_getattr,

	.setattr	= kvm_gmem_setattr,

};