Commit 87eba5bc authored by Waiman Long's avatar Waiman Long Committed by Tejun Heo
Browse files

cgroup/cpuset: Remove the unnecessary css_get/put() in cpuset_partition_write() 



The css_get/put() calls in cpuset_partition_write() are unnecessary as
an active reference of the kernfs node will be taken which will prevent
its removal and guarantee the existence of the css. Only the online
check is needed.

Signed-off-by: default avatarWaiman Long <longman@redhat.com>
Reviewed-by: default avatarMichal Koutný <mkoutny@suse.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 150e298a

kernel/cgroup/cpuset.c

+0 −2
Original line number Diff line number Diff line
@@ -3358,14 +3358,12 @@ static ssize_t cpuset_partition_write(struct kernfs_open_file *of, char *buf, 
	else

		return -EINVAL;



	css_get(&cs->css);

	cpus_read_lock();

	mutex_lock(&cpuset_mutex);

	if (is_cpuset_online(cs))

		retval = update_prstate(cs, val);

	mutex_unlock(&cpuset_mutex);

	cpus_read_unlock();

	css_put(&cs->css);

	return retval ?: nbytes;

}