Commit 88325a29 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: dsa: require .support_eee() method to be implemented 



Now that we have updated all drivers, switch DSA to require an
implementation of the .support_eee() method for EEE to be usable,
rather than defaulting to being permissive when not implemented.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Link: https://patch.msgid.link/E1tL14e-006cZy-AT@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 801fd546

net/dsa/user.c

+2 −2
Original line number Diff line number Diff line
@@ -1230,7 +1230,7 @@ static int dsa_user_set_eee(struct net_device *dev, struct ethtool_keee *e) 
	int ret;



	/* Check whether the switch supports EEE */

	if (ds->ops->support_eee && !ds->ops->support_eee(ds, dp->index))

	if (!ds->ops->support_eee || !ds->ops->support_eee(ds, dp->index))

		return -EOPNOTSUPP;



	/* Port's PHY and MAC both need to be EEE capable */
@@ -1254,7 +1254,7 @@ static int dsa_user_get_eee(struct net_device *dev, struct ethtool_keee *e) 
	int ret;



	/* Check whether the switch supports EEE */

	if (ds->ops->support_eee && !ds->ops->support_eee(ds, dp->index))

	if (!ds->ops->support_eee || !ds->ops->support_eee(ds, dp->index))

		return -EOPNOTSUPP;



	/* Port's PHY and MAC both need to be EEE capable */