Unverified Commit 88340fc8 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: soc-core: add lockdep_assert_held() at snd_soc_unregister_dai() 



snd_soc_register_dai()           has  lockdep_assert_held() (A), but
snd_soc_unregister_dai() doesn't have lockdep_assert_held() (B).

	void snd_soc_unregister_dai(...)
	{
(B)		dev_dbg(...);
		list_del(...);
	}

	struct snd_soc_dai *snd_soc_register_dai(...)
	{
		...
(A)		lockdep_assert_held(&client_mutex);
		...
	}

Both functions should be called with client_mutex lock.
Add missing lockdep_assert_held() at snd_soc_unregister_dai().

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/87jyx21nu4.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ab3f4f0c

sound/soc/soc-core.c

+2 −0
Original line number Diff line number Diff line
@@ -2679,6 +2679,8 @@ static inline char *fmt_multiple_name(struct device *dev, 


void snd_soc_unregister_dai(struct snd_soc_dai *dai)

{

	lockdep_assert_held(&client_mutex);



	dev_dbg(dai->dev, "ASoC: Unregistered DAI '%s'\n", dai->name);

	list_del(&dai->list);

}