Commit 8844f467 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Abhinav Kumar
Browse files

drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more sensible 



There is little point in using %ps to print a value known to be NULL. On
the other hand it makes sense to print the callback symbol in the
'invalid IRQ' message. Correct those two error messages to make more
sense.

Fixes: 68931991 ("drm/msm/dpu: stop using raw IRQ indices in the kernel output")
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/585565/
Link: https://lore.kernel.org/r/20240330-dpu-irq-messages-v1-1-9ce782ae35f9@linaro.org


Signed-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
parent ee15c8bf

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c

+4 −4
Original line number Diff line number Diff line
@@ -525,14 +525,14 @@ int dpu_core_irq_register_callback(struct dpu_kms *dpu_kms, 
	int ret;



	if (!irq_cb) {

		DPU_ERROR("invalid IRQ=[%d, %d] irq_cb:%ps\n",

			  DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx), irq_cb);

		DPU_ERROR("IRQ=[%d, %d] NULL callback\n",

			  DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx));

		return -EINVAL;

	}



	if (!dpu_core_irq_is_valid(irq_idx)) {

		DPU_ERROR("invalid IRQ=[%d, %d]\n",

			  DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx));

		DPU_ERROR("invalid IRQ=[%d, %d] irq_cb:%ps\n",

			  DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx), irq_cb);

		return -EINVAL;

	}