Commit 8857f249 authored by Michael Wu's avatar Michael Wu Committed by Chanwoo Choi
Browse files

extcon: Fixed sysfs duplicate filename issue 



With current extcon_dev_unregister() timing, ida_free is before
device_unregister(), that may cause current id re-alloc to another
device in extcon_dev_register() context but sysfs filename path not
removal completed yet.

The right timing shows below:
on extcon_dev_register: ida_alloc() -> device_register()
on extcon_dev_unregister: device_unregister() -> ida_free()

stack information when an error occurs:
sysfs: cannot create duplicate filename '/class/extcon/extcon1'
Call trace:
 sysfs_warn_dup+0x68/0x88
 sysfs_do_create_link_sd+0x94/0xdc
 sysfs_create_link+0x30/0x48
 device_add_class_symlinks+0xb4/0x12c
 device_add+0x1e0/0x48c
 device_register+0x20/0x34
 extcon_dev_register+0x3b8/0x5c4

Fixes: 7bba9e81 ("extcon: Use unique number for the extcon device ID")
Acked-by: default avatarMyungJoo Ham <myungjoo.ham@samsung.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarMichael Wu <michael@allwinnertech.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Link: https://lore.kernel.org/lkml/20251024024946.16618-1-michael@allwinnertech.com/
parent 6a4d20fe

drivers/extcon/extcon.c

+2 −2
Original line number Diff line number Diff line
@@ -1366,10 +1366,10 @@ void extcon_dev_unregister(struct extcon_dev *edev) 
		return;

	}



	ida_free(&extcon_dev_ids, edev->id);



	device_unregister(&edev->dev);



	ida_free(&extcon_dev_ids, edev->id);



	if (edev->mutually_exclusive && edev->max_supported) {

		for (index = 0; edev->mutually_exclusive[index];

				index++)