Commit 8879a3c1 authored by Thorsten Blum's avatar Thorsten Blum Committed by Herbert Xu
Browse files

crypto: af_alg - use sock_kmemdup in alg_setkey_by_key_serial 



Replace sock_kmalloc() followed by memcpy() with sock_kmemdup() to
simplify alg_setkey_by_key_serial().

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent c697c5fc

crypto/af_alg.c

+1 −3
Original line number Diff line number Diff line
@@ -324,15 +324,13 @@ static int alg_setkey_by_key_serial(struct alg_sock *ask, sockptr_t optval, 
		return PTR_ERR(ret);

	}



	key_data = sock_kmalloc(&ask->sk, key_datalen, GFP_KERNEL);

	key_data = sock_kmemdup(&ask->sk, ret, key_datalen, GFP_KERNEL);

	if (!key_data) {

		up_read(&key->sem);

		key_put(key);

		return -ENOMEM;

	}



	memcpy(key_data, ret, key_datalen);



	up_read(&key->sem);

	key_put(key);