Commit 88a71941 authored by Koichiro Den's avatar Koichiro Den Committed by Bjorn Helgaas
Browse files

PCI: dwc: ep: Return after clearing BAR-match inbound mapping 



dw_pcie_ep_clear_ib_maps() first checks whether the inbound mapping for a
BAR is in BAR Match Mode (tracked via ep_func->bar_to_atu[bar]). Once
found, the iATU region is disabled and the bookkeeping is cleared.

BAR Match Mode and Address Match Mode mappings are mutually exclusive for a
given BAR, so there is nothing left for the Address Match Mode teardown
path to do after the BAR Match Mode mapping has been removed.

Return early after clearing the BAR Match Mode mapping to avoid running the
Address Match Mode teardown path. This makes the helper's intention
explicit and helps detect incorrect use of pci_epc_set_bar().

Suggested-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarKoichiro Den <den@valinux.co.jp>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Link: https://patch.msgid.link/20260202145407.503348-2-den@valinux.co.jp
parent 5ddb6696

drivers/pci/controller/dwc/pcie-designware-ep.c

+1 −0
Original line number Diff line number Diff line
@@ -165,6 +165,7 @@ static void dw_pcie_ep_clear_ib_maps(struct dw_pcie_ep *ep, u8 func_no, enum pci 
		dw_pcie_disable_atu(pci, PCIE_ATU_REGION_DIR_IB, atu_index);

		clear_bit(atu_index, ep->ib_window_map);

		ep_func->bar_to_atu[bar] = 0;

		return;

	}



	/* Tear down all Address Match Mode mappings, if any. */