Commit 88bf68b7 authored by Ulf Hansson's avatar Ulf Hansson
Browse files

cpuidle: psci: Drop redundant assignment of CPUIDLE_FLAG_RCU_IDLE 



When using the hierarchical topology and PSCI OSI-mode we may end up
overriding the deepest idle-state's ->enter|enter_s2idle() callbacks, but
there is no point to also re-assign the CPUIDLE_FLAG_RCU_IDLE for the
idle-state in question, as that has already been set when parsing the
states from DT. See init_state_node().

Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Tested-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>  # qcm6490 with PREEMPT_RT set
Acked-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20240527142557.321610-6-ulf.hansson@linaro.org
parent c7b45284

drivers/cpuidle/cpuidle-psci.c

+0 −1
Original line number Diff line number Diff line
@@ -234,7 +234,6 @@ static int psci_dt_cpu_init_topology(struct cpuidle_driver *drv, 
	 * of a shared state for the domain, assumes the domain states are all

	 * deeper states.

	 */

	drv->states[state_count - 1].flags |= CPUIDLE_FLAG_RCU_IDLE;

	drv->states[state_count - 1].enter = psci_enter_domain_idle_state;

	drv->states[state_count - 1].enter_s2idle = psci_enter_s2idle_domain_idle_state;

	psci_cpuidle_use_cpuhp = true;