Commit 88daf2f4 authored by Matvey Kovalev's avatar Matvey Kovalev Committed by Steve French
Browse files

ksmbd: fix error code overwriting in smb2_get_info_filesystem() 



If client doesn't negotiate with SMB3.1.1 POSIX Extensions,
then proper error code won't be returned due to overwriting.

Return error immediately.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: e2f34481 ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMatvey Kovalev <matvey.kovalev@ispras.ru>
Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent c20988c2

fs/smb/server/smb2pdu.c

+2 −1
Original line number Diff line number Diff line
@@ -5629,7 +5629,8 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, 


		if (!work->tcon->posix_extensions) {

			pr_err("client doesn't negotiate with SMB3.1.1 POSIX Extensions\n");

			rc = -EOPNOTSUPP;

			path_put(&path);

			return -EOPNOTSUPP;

		} else {

			info = (struct filesystem_posix_info *)(rsp->Buffer);

			info->OptimalTransferSize = cpu_to_le32(stfs.f_bsize);