Commit 88ecb66b authored by Rodrigo Vivi's avatar Rodrigo Vivi Committed by Lucas De Marchi
Browse files

drm/xe: Restore EIO errno return when GuC PC start fails 



Commit b4b05e53 ("drm/xe/guc_pc: Retry and wait longer for GuC PC
start"), leads to the following Smatch static checker warning:

        drivers/gpu/drm/xe/xe_guc_pc.c:1073 xe_guc_pc_start()
        warn: missing error code here? '_dev_err()' failed. 'ret' = '0'

Fixes: c605acb5 ("drm/xe/guc_pc: Retry and wait longer for GuC PC start")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-xe/1454a5f1-ee18-4df1-a6b2-a4a3dddcd1cb@stanley.mountain/


Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250328181752.26677-1-rodrigo.vivi@intel.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit 3f2bdccb)
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent e775278c

drivers/gpu/drm/xe/xe_guc_pc.c

+1 −0
Original line number Diff line number Diff line
@@ -1070,6 +1070,7 @@ int xe_guc_pc_start(struct xe_guc_pc *pc) 
		if (wait_for_pc_state(pc, SLPC_GLOBAL_STATE_RUNNING,

				      SLPC_RESET_EXTENDED_TIMEOUT_MS)) {

			xe_gt_err(gt, "GuC PC Start failed: Dynamic GT frequency control and GT sleep states are now disabled.\n");

			ret = -EIO;

			goto out;

		}