Commit 88f04bc3 authored by Kunwu Chan's avatar Kunwu Chan Committed by Sebastian Reichel
Browse files

power: supply: Fix null pointer dereference in smb2_probe 



devm_kasprintf and devm_kzalloc return a pointer to dynamically
allocated memory which can be NULL upon failure.

Fixes: 8648aeb5 ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver")
Signed-off-by: default avatarKunwu Chan <chentao@kylinos.cn>
Link: https://lore.kernel.org/r/20231124075021.1335289-1-chentao@kylinos.cn


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 195c3167

drivers/power/supply/qcom_pmi8998_charger.c

+4 −0
Original line number Diff line number Diff line
@@ -972,10 +972,14 @@ static int smb2_probe(struct platform_device *pdev) 
	supply_config.of_node = pdev->dev.of_node;



	desc = devm_kzalloc(chip->dev, sizeof(smb2_psy_desc), GFP_KERNEL);

	if (!desc)

		return -ENOMEM;

	memcpy(desc, &smb2_psy_desc, sizeof(smb2_psy_desc));

	desc->name =

		devm_kasprintf(chip->dev, GFP_KERNEL, "%s-charger",

			       (const char *)device_get_match_data(chip->dev));

	if (!desc->name)

		return -ENOMEM;



	chip->chg_psy =

		devm_power_supply_register(chip->dev, desc, &supply_config);