Unverified Commit 890ed45b authored Feb 11, 2025 by Christian Brauner

acct: block access to kernel internal filesystems

There's no point in allowing anything kernel internal nor procfs or
sysfs.

Link: https://lore.kernel.org/r/20250127091811.3183623-1-quzicheng@huawei.com
Link: https://lore.kernel.org/r/20250211-work-acct-v1-2-1c16aecab8b3@kernel.org


Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reported-by: Zicheng Qu <quzicheng@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>

parent 56d5f3eb

kernel/acct.c

+14 −0

Original line number	Diff line number	Diff line
		@@ -243,6 +243,20 @@ static int acct_on(struct filename *pathname)
		return -EACCES;
		}

		/* Exclude kernel kernel internal filesystems. */
		if (file_inode(file)->i_sb->s_flags & (SB_NOUSER \| SB_KERNMOUNT)) {
		kfree(acct);
		filp_close(file, NULL);
		return -EINVAL;
		}

		/* Exclude procfs and sysfs. */
		if (file_inode(file)->i_sb->s_iflags & SB_I_USERNS_VISIBLE) {
		kfree(acct);
		filp_close(file, NULL);
		return -EINVAL;
		}

		if (!(file->f_mode & FMODE_CAN_WRITE)) {
		kfree(acct);
		filp_close(file, NULL);