Commit 89394e03 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/fbdev: Select linear modifier explicitly 



Currently we use the implicit modifier fb creation path for fbdev,
but as we never call set_tiling on the bo it will always end up as
linear anyway. The rest of the code (eg. stride alignment) also
assumes that we'll use linear. Just select the linear modifier
explicitly.

Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20251003145734.7634-4-ville.syrjala@linux.intel.com
parent 1d1e4ded

drivers/gpu/drm/i915/display/intel_fbdev.c

+2 −0
Original line number Diff line number Diff line
@@ -214,12 +214,14 @@ static void intel_fbdev_fill_mode_cmd(struct drm_fb_helper_surface_size *sizes, 
	if (sizes->surface_bpp == 24)

		sizes->surface_bpp = 32;



	mode_cmd->flags = DRM_MODE_FB_MODIFIERS;

	mode_cmd->width = sizes->surface_width;

	mode_cmd->height = sizes->surface_height;



	mode_cmd->pitches[0] = ALIGN(mode_cmd->width * DIV_ROUND_UP(sizes->surface_bpp, 8), 64);

	mode_cmd->pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,

							   sizes->surface_depth);

	mode_cmd->modifier[0] = DRM_FORMAT_MOD_LINEAR;

}



static struct intel_framebuffer *