Commit 894d7508 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde Committed by David S. Miller
Browse files

net: netdev_queue: netdev_txq_completed_mb(): fix wake condition 



netif_txq_try_stop() uses "get_desc >= start_thrs" as the check for
the call to netif_tx_start_queue().

Use ">=" i netdev_txq_completed_mb(), too.

Fixes: c91c46de ("net: provide macros for commonly copied lockless queue stop/wake code")
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9181d6f8

include/net/netdev_queues.h

+1 −1
Original line number Diff line number Diff line
@@ -128,7 +128,7 @@ netdev_txq_completed_mb(struct netdev_queue *dev_queue, 
		netdev_txq_completed_mb(txq, pkts, bytes);		\

									\

		_res = -1;						\

		if (pkts && likely(get_desc > start_thrs)) {		\

		if (pkts && likely(get_desc >= start_thrs)) {		\

			_res = 1;					\

			if (unlikely(netif_tx_queue_stopped(txq)) &&	\

			    !(down_cond)) {				\