Commit 895621f1 authored by Kalesh AP's avatar Kalesh AP Committed by Jakub Kicinski
Browse files

bnxt_en: Don't support offline self test when RoCE driver is loaded 



Offline self test is a very disruptive operation for RoCE and requires
all active QPs to be destroyed.  With a large number of QPs, it can
take a long time to destroy all the QPs and can timeout.  Do not allow
ethtool offline self test if the RoCE driver is registered on the
device.

Reviewed-by: default avatarSelvin Thyparampil Xavier <selvin.xavier@broadcom.com>
Reviewed-by: default avatarVikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240501003056.100607-3-michael.chan@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a75fbb3a

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+8 −3
Original line number Diff line number Diff line
@@ -4820,6 +4820,14 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest, 


	if (!bp->num_tests || !BNXT_PF(bp))

		return;



	if (etest->flags & ETH_TEST_FL_OFFLINE &&

	    bnxt_ulp_registered(bp->edev)) {

		etest->flags |= ETH_TEST_FL_FAILED;

		netdev_warn(dev, "Offline tests cannot be run with RoCE driver loaded\n");

		return;

	}



	memset(buf, 0, sizeof(u64) * bp->num_tests);

	if (!netif_running(dev)) {

		etest->flags |= ETH_TEST_FL_FAILED;
@@ -4850,7 +4858,6 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest, 
	if (!offline) {

		bnxt_run_fw_tests(bp, test_mask, &test_results);

	} else {

		bnxt_ulp_stop(bp);

		bnxt_close_nic(bp, true, false);

		bnxt_run_fw_tests(bp, test_mask, &test_results);
@@ -4861,7 +4868,6 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest, 
		if (rc) {

			bnxt_hwrm_mac_loopback(bp, false);

			etest->flags |= ETH_TEST_FL_FAILED;

			bnxt_ulp_start(bp, rc);

			return;

		}

		if (bnxt_run_loopback(bp))
@@ -4888,7 +4894,6 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest, 
		bnxt_hwrm_phy_loopback(bp, false, false);

		bnxt_half_close_nic(bp);

		rc = bnxt_open_nic(bp, true, true);

		bnxt_ulp_start(bp, rc);

	}

	if (rc || bnxt_test_irq(bp)) {

		buf[BNXT_IRQ_TEST_IDX] = 1;