Commit 896f6966 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Martin K. Petersen
Browse files

scsi: megaraid: Fix a sleep-in-atomic bug 



The driver may sleep under a spin lock, and the function call path is:
mraid_mm_attach_buf (acquire the lock by spin_lock_irqsave)
  pci_pool_alloc(GFP_KERNEL) --> may sleep

To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".

[mkp: fixed whitespace]

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@163.com>
Acked-by: default avatarSumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 566ec9ad

drivers/scsi/megaraid/megaraid_mm.c

+1 −1
Original line number Diff line number Diff line
@@ -574,7 +574,7 @@ mraid_mm_attach_buf(mraid_mmadp_t *adp, uioc_t *kioc, int xferlen) 


	kioc->pool_index	= right_pool;

	kioc->free_buf		= 1;

	kioc->buf_vaddr 	= pci_pool_alloc(pool->handle, GFP_KERNEL,

	kioc->buf_vaddr		= pci_pool_alloc(pool->handle, GFP_ATOMIC,

							&kioc->buf_paddr);

	spin_unlock_irqrestore(&pool->lock, flags);