Commit 897d68d4 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: allow non-partner GET_PDOS for Qualcomm devices 



The name and description of the USB_NO_PARTNER_PDOS quirk specifies that
only retrieving PDOS of the attached device is crashing. Retrieving PDOS
of the UCSI device works. Fix the condition to limit the workaround only
to is_partner cases.

Fixes: 1d103d6a ("usb: typec: ucsi: fix UCSI on buggy Qualcomm devices")
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240329-qcom-ucsi-fixes-v2-1-0f5d37ed04db@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent db2ed6ec

drivers/usb/typec/ucsi/ucsi.c

+2 −1
Original line number Diff line number Diff line
@@ -619,7 +619,8 @@ static int ucsi_read_pdos(struct ucsi_connector *con, 
	u64 command;

	int ret;



	if (ucsi->quirks & UCSI_NO_PARTNER_PDOS)

	if (is_partner &&

	    ucsi->quirks & UCSI_NO_PARTNER_PDOS)

		return 0;



	command = UCSI_COMMAND(UCSI_GET_PDOS) | UCSI_CONNECTOR_NUMBER(con->num);