Commit 899c0e8a authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Kalle Valo
Browse files

wifi: mwifiex: Use helpers to check multicast addresses 



Use is_multicast_ether_addr() and is_unicast_ether_addr()
to check the addresses.

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20230814124212.302738-3-ruanjinjie@huawei.com
parent 47f0e32f

drivers/net/wireless/marvell/mwifiex/cfg80211.c

+1 −1
Original line number Diff line number Diff line
@@ -3359,7 +3359,7 @@ static int mwifiex_set_wowlan_mef_entry(struct mwifiex_private *priv, 
		}



		if (!wowlan->patterns[i].pkt_offset) {

			if (!(byte_seq[0] & 0x01) &&

			if (is_unicast_ether_addr(byte_seq) &&

			    (byte_seq[MWIFIEX_MEF_MAX_BYTESEQ] == 1)) {

				mef_cfg->criteria |= MWIFIEX_CRITERIA_UNICAST;

				continue;

drivers/net/wireless/marvell/mwifiex/wmm.c

+1 −1
Original line number Diff line number Diff line
@@ -871,7 +871,7 @@ mwifiex_wmm_add_buf_txqueue(struct mwifiex_private *priv, 
		}

	} else {

		memcpy(ra, skb->data, ETH_ALEN);

		if (ra[0] & 0x01 || mwifiex_is_skb_mgmt_frame(skb))

		if (is_multicast_ether_addr(ra) || mwifiex_is_skb_mgmt_frame(skb))

			eth_broadcast_addr(ra);

		ra_list = mwifiex_wmm_get_queue_raptr(priv, tid_down, ra);

	}