Commit 89aa5925 authored by Anastasia Belova's avatar Anastasia Belova Committed by Bjorn Andersson
Browse files

clk: qcom: clk-rpmh: prevent integer overflow in recalc_rate 



aggr_state and unit fields are u32. The result of their
multiplication may not fit in this type.

Add explicit casting to prevent overflow.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 04053f4d ("clk: qcom: clk-rpmh: Add IPA clock support")
Cc: stable@vger.kernel.org # 5.4+
Signed-off-by: default avatarAnastasia Belova <abelova@astralinux.ru>
Link: https://lore.kernel.org/r/20241203084231.6001-1-abelova@astralinux.ru


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 39d6dcf6

drivers/clk/qcom/clk-rpmh.c

+1 −1
Original line number Diff line number Diff line
@@ -329,7 +329,7 @@ static unsigned long clk_rpmh_bcm_recalc_rate(struct clk_hw *hw, 
{

	struct clk_rpmh *c = to_clk_rpmh(hw);



	return c->aggr_state * c->unit;

	return (unsigned long)c->aggr_state * c->unit;

}



static const struct clk_ops clk_rpmh_bcm_ops = {