Commit 89ffb2c3 authored by Vasant Hegde's avatar Vasant Hegde Committed by Joerg Roedel
Browse files

iommu/amd: Make amd_iommu_dev_update_dte() static 



As its used inside iommu.c only. Also rename function to dev_update_dte()
as its static function.

No functional changes intended.

Signed-off-by: default avatarVasant Hegde <vasant.hegde@amd.com>
Reviewed-by: default avatarSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Link: https://lore.kernel.org/r/20240828111029.5429-9-vasant.hegde@amd.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent a3303762

drivers/iommu/amd/amd_iommu.h

+0 −1
Original line number Diff line number Diff line
@@ -87,7 +87,6 @@ int amd_iommu_complete_ppr(struct device *dev, u32 pasid, int status, int tag); 
void amd_iommu_flush_all_caches(struct amd_iommu *iommu);

void amd_iommu_update_and_flush_device_table(struct protection_domain *domain);

void amd_iommu_domain_update(struct protection_domain *domain);

void amd_iommu_dev_update_dte(struct iommu_dev_data *dev_data, bool set);

void amd_iommu_domain_flush_pages(struct protection_domain *domain,

				  u64 address, size_t size);

void amd_iommu_dev_flush_pasid_pages(struct iommu_dev_data *dev_data,

drivers/iommu/amd/iommu.c

+4 −4
Original line number Diff line number Diff line
@@ -1955,7 +1955,7 @@ static void clear_dte_entry(struct amd_iommu *iommu, u16 devid) 
}



/* Update and flush DTE for the given device */

void amd_iommu_dev_update_dte(struct iommu_dev_data *dev_data, bool set)

static void dev_update_dte(struct iommu_dev_data *dev_data, bool set)

{

	struct amd_iommu *iommu = get_amd_iommu_from_dev(dev_data->dev);
@@ -2055,7 +2055,7 @@ static void do_detach(struct iommu_dev_data *dev_data) 
	struct amd_iommu *iommu = get_amd_iommu_from_dev_data(dev_data);



	/* Clear DTE and flush the entry */

	amd_iommu_dev_update_dte(dev_data, false);

	dev_update_dte(dev_data, false);



	/* Flush IOTLB and wait for the flushes to finish */

	amd_iommu_domain_flush_all(domain);
@@ -2467,7 +2467,7 @@ static int blocked_domain_attach_device(struct iommu_domain *domain, 


	/* Clear DTE and flush the entry */

	spin_lock(&dev_data->lock);

	amd_iommu_dev_update_dte(dev_data, false);

	dev_update_dte(dev_data, false);

	spin_unlock(&dev_data->lock);



	return 0;
@@ -2535,7 +2535,7 @@ static int amd_iommu_attach_device(struct iommu_domain *dom, 
	}



	/* Update device table */

	amd_iommu_dev_update_dte(dev_data, true);

	dev_update_dte(dev_data, true);



	return ret;

}