Commit 8a040e13 authored by Kathiravan Thirumoorthy's avatar Kathiravan Thirumoorthy Committed by Vinod Koul
Browse files

Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424" 



With the current settings, compliance tests especially eye diagram
(Host High-speed Signal Quality) tests are failing. Reuse the IPQ6018
settings to overcome this issue, as mentioned in the Hardware Design
Document.

So revert the change which introduced the new settings and reuse the
IPQ6018 settings in the subsequent patch.

Fixes: 9c56a1de ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
Signed-off-by: default avatarKathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250415-revert_hs_phy_settings-v3-1-3a8f86211b59@oss.qualcomm.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 74c2524a

drivers/phy/qualcomm/phy-qcom-qusb2.c

+0 −28
Original line number Diff line number Diff line
@@ -151,21 +151,6 @@ static const struct qusb2_phy_init_tbl ipq6018_init_tbl[] = { 
	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F),

};



static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = {

	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14),

	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00),

	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53),

	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3),

	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30),

	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79),

	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21),

	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00),

	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00),

	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14),

	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80),

	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),

};



static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = {

	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8),

	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3),
@@ -359,16 +344,6 @@ static const struct qusb2_phy_cfg ipq6018_phy_cfg = { 
	.autoresume_en   = BIT(0),

};



static const struct qusb2_phy_cfg ipq5424_phy_cfg = {

	.tbl            = ipq5424_init_tbl,

	.tbl_num        = ARRAY_SIZE(ipq5424_init_tbl),

	.regs           = ipq6018_regs_layout,



	.disable_ctrl   = POWER_DOWN,

	.mask_core_ready = PLL_LOCKED,

	.autoresume_en   = BIT(0),

};



static const struct qusb2_phy_cfg qcs615_phy_cfg = {

	.tbl            = qcs615_init_tbl,

	.tbl_num        = ARRAY_SIZE(qcs615_init_tbl),
@@ -954,9 +929,6 @@ static const struct phy_ops qusb2_phy_gen_ops = { 


static const struct of_device_id qusb2_phy_of_match_table[] = {

	{

		.compatible	= "qcom,ipq5424-qusb2-phy",

		.data		= &ipq5424_phy_cfg,

	}, {

		.compatible	= "qcom,ipq6018-qusb2-phy",

		.data		= &ipq6018_phy_cfg,

	}, {