Unverified Commit 8a066a81 authored by Cédric Bellegarde's avatar Cédric Bellegarde Committed by Mark Brown
Browse files

ASoC: qcom: q6asm: drop DSP responses for closed data streams 



'Commit a354f030 ("ASoC: qcom: q6asm: handle the responses
after closing")' attempted to ignore DSP responses arriving
after a stream had been closed.

However, those responses were still handled, causing lockups.

Fix this by unconditionally dropping all DSP responses associated with
closed data streams.

Signed-off-by: default avatarCédric Bellegarde <cedric.bellegarde@adishatz.org>
Link: https://patch.msgid.link/20260102215225.609166-1-cedric.bellegarde@adishatz.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 090c8844

sound/soc/qcom/qdsp6/q6asm.c

+2 −2
Original line number Diff line number Diff line
@@ -636,7 +636,6 @@ static int32_t q6asm_stream_callback(struct apr_device *adev, 
			client_event = ASM_CLIENT_EVENT_CMD_OUT_FLUSH_DONE;

			break;

		case ASM_STREAM_CMD_OPEN_WRITE_V3:

		case ASM_DATA_CMD_WRITE_V2:

		case ASM_STREAM_CMD_OPEN_READ_V3:

		case ASM_STREAM_CMD_OPEN_READWRITE_V2:

		case ASM_STREAM_CMD_SET_ENCDEC_PARAM:
@@ -655,8 +654,9 @@ static int32_t q6asm_stream_callback(struct apr_device *adev, 
			break;

		case ASM_DATA_CMD_EOS:

		case ASM_DATA_CMD_READ_V2:

		case ASM_DATA_CMD_WRITE_V2:

			/* response as result of close stream */

			break;

			goto done;

		default:

			dev_err(ac->dev, "command[0x%x] not expecting rsp\n",

				result->opcode);