Commit 8a157d2f authored by Mathias Nyman's avatar Mathias Nyman Committed by Greg Kroah-Hartman
Browse files

xhci: check port array allocation was successful before dereferencing it 



return if rhub->ports is null after rhub->ports = kcalloc_node()
Klockwork reported issue

Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20210406070208.3406266-2-mathias.nyman@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f70d436f

drivers/usb/host/xhci-mem.c

+3 −0
Original line number Diff line number Diff line
@@ -2249,6 +2249,9 @@ static void xhci_create_rhub_port_array(struct xhci_hcd *xhci, 
		return;

	rhub->ports = kcalloc_node(rhub->num_ports, sizeof(*rhub->ports),

			flags, dev_to_node(dev));

	if (!rhub->ports)

		return;



	for (i = 0; i < HCS_MAX_PORTS(xhci->hcs_params1); i++) {

		if (xhci->hw_ports[i].rhub != rhub ||

		    xhci->hw_ports[i].hcd_portnum == DUPLICATE_ENTRY)