Commit 8a1c099f authored by Fabio Estevam's avatar Fabio Estevam Committed by Sebastian Reichel
Browse files

power: reset: gpio-poweroff: Clarify the warning message 



When gpio-poweroff fails, a WARN_ON() is triggered without
an explanation to the user about the failure.

Add some comments explaining that the attempt to poweroff the system
via gpio-poweroff failed and convert it to a WARN() message with a
bit of context to provide some hint to the user.

Signed-off-by: default avatarFabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20241212130456.580197-1-festevam@gmail.com


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent cc4c3457

drivers/power/reset/gpio-poweroff.c

+7 −1
Original line number Diff line number Diff line
@@ -44,7 +44,13 @@ static int gpio_poweroff_do_poweroff(struct sys_off_data *data) 
	/* give it some time */

	mdelay(gpio_poweroff->timeout_ms);



	WARN_ON(1);

	/*

	 * If code reaches this point, it means that gpio-poweroff has failed

	 * to actually power off the system.

	 * Warn the user that the attempt to poweroff via gpio-poweroff

	 * has gone wrong.

	 */

	WARN(1, "Failed to poweroff via gpio-poweroff mechanism\n");



	return NOTIFY_DONE;

}