Commit 8a4bc450 authored by Liao Yuanhong's avatar Liao Yuanhong Committed by Alex Deucher
Browse files

drm/amdgpu/ih: Remove redundant ternary operators 



For ternary operators in the form of "a ? false : true", if 'a' itself
returns a boolean result, the ternary operator can be omitted. Remove
redundant ternary operators to clean up the code.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarLiao Yuanhong <liaoyuanhong@vivo.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 60df3e81

drivers/gpu/drm/amd/amdgpu/ih_v6_0.c

+1 −2
Original line number Diff line number Diff line
@@ -587,8 +587,7 @@ static int ih_v6_0_sw_init(struct amdgpu_ip_block *ip_block) 
	/* use gpu virtual address for ih ring

	 * until ih_checken is programmed to allow

	 * use bus address for ih ring by psp bl */

	use_bus_addr =

		(adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) ? false : true;

	use_bus_addr = adev->firmware.load_type != AMDGPU_FW_LOAD_PSP;

	r = amdgpu_ih_ring_init(adev, &adev->irq.ih, IH_RING_SIZE, use_bus_addr);

	if (r)

		return r;

drivers/gpu/drm/amd/amdgpu/ih_v6_1.c

+1 −2
Original line number Diff line number Diff line
@@ -562,8 +562,7 @@ static int ih_v6_1_sw_init(struct amdgpu_ip_block *ip_block) 
	/* use gpu virtual address for ih ring

	 * until ih_checken is programmed to allow

	 * use bus address for ih ring by psp bl */

	use_bus_addr =

		(adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) ? false : true;

	use_bus_addr = adev->firmware.load_type != AMDGPU_FW_LOAD_PSP;

	r = amdgpu_ih_ring_init(adev, &adev->irq.ih, 256 * 1024, use_bus_addr);

	if (r)

		return r;

drivers/gpu/drm/amd/amdgpu/ih_v7_0.c

+1 −2
Original line number Diff line number Diff line
@@ -552,8 +552,7 @@ static int ih_v7_0_sw_init(struct amdgpu_ip_block *ip_block) 
	/* use gpu virtual address for ih ring

	 * until ih_checken is programmed to allow

	 * use bus address for ih ring by psp bl */

	use_bus_addr =

		(adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) ? false : true;

	use_bus_addr = adev->firmware.load_type != AMDGPU_FW_LOAD_PSP;

	r = amdgpu_ih_ring_init(adev, &adev->irq.ih, 256 * 1024, use_bus_addr);

	if (r)

		return r;