Commit 8a81236f authored by Gunnar Kudrjavets's avatar Gunnar Kudrjavets Committed by Jarkko Sakkinen
Browse files

tpm_tis: Fix incorrect arguments in tpm_tis_probe_irq_single 



The tpm_tis_write8() call specifies arguments in wrong order. Should be
(data, addr, value) not (data, value, addr). The initial correct order
was changed during the major refactoring when the code was split.

Fixes: 41a5e1cf ("tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy")
Signed-off-by: default avatarGunnar Kudrjavets <gunnarku@amazon.com>
Reviewed-by: default avatarJustinien Bouron <jbouron@amazon.com>
Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: default avatarPaul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent 64a7cfbc

drivers/char/tpm/tpm_tis_core.c

+2 −2
Original line number Diff line number Diff line
@@ -978,8 +978,8 @@ static int tpm_tis_probe_irq_single(struct tpm_chip *chip, u32 intmask, 
	 * will call disable_irq which undoes all of the above.

	 */

	if (!(chip->flags & TPM_CHIP_FLAG_IRQ)) {

		tpm_tis_write8(priv, original_int_vec,

			       TPM_INT_VECTOR(priv->locality));

		tpm_tis_write8(priv, TPM_INT_VECTOR(priv->locality),

			       original_int_vec);

		rc = -1;

	}