Commit 8aa6f769 authored by Gabor Juhos's avatar Gabor Juhos Committed by Ulf Hansson
Browse files

pmdomain: qcom: rpmpd: fix off-by-one error in clamping to the highest state 



As it is indicated by the comment, the rpmpd_aggregate_corner() function
tries to clamp the state to the highest corner/level supported by the
given power domain, however the calculation of the highest state contains
an off-by-one error.

The 'max_state' member of the 'rpmpd' structure indicates the highest
corner/level, and as such it does not needs to be decremented.

Change the code to use the 'max_state' value directly to avoid the error.

Fixes: 98c8b3ef ("soc: qcom: rpmpd: Add sync_state")
Signed-off-by: default avatarGabor Juhos <j4g8y7@gmail.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 861d21c4

drivers/pmdomain/qcom/rpmpd.c

+1 −1
Original line number Diff line number Diff line
@@ -1001,7 +1001,7 @@ static int rpmpd_aggregate_corner(struct rpmpd *pd) 


	/* Clamp to the highest corner/level if sync_state isn't done yet */

	if (!pd->state_synced)

		this_active_corner = this_sleep_corner = pd->max_state - 1;

		this_active_corner = this_sleep_corner = pd->max_state;

	else

		to_active_sleep(pd, pd->corner, &this_active_corner, &this_sleep_corner);