Commit 8aabc03c authored by Rosen Penev's avatar Rosen Penev Committed by Kalle Valo
Browse files

wifi: ath9k: use devm for gpio_request_one() 



Using devm_gpio_request_one() is simpler as then we don't need to call
gpio_free().

Signed-off-by: default avatarRosen Penev <rosenp@gmail.com>
Acked-by: default avatarToke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240731210312.7622-1-rosenp@gmail.com
parent 92da4ce8

drivers/net/wireless/ath/ath9k/hw.c

+2 −4
Original line number Diff line number Diff line
@@ -2732,7 +2732,7 @@ static void ath9k_hw_gpio_cfg_soc(struct ath_hw *ah, u32 gpio, bool out, 
	if (ah->caps.gpio_requested & BIT(gpio))

		return;



	err = gpio_request_one(gpio, out ? GPIOF_OUT_INIT_LOW : GPIOF_IN, label);

	err = devm_gpio_request_one(ah->dev, gpio, out ? GPIOF_OUT_INIT_LOW : GPIOF_IN, label);

	if (err) {

		ath_err(ath9k_hw_common(ah), "request GPIO%d failed:%d\n",

			gpio, err);
@@ -2801,11 +2801,9 @@ void ath9k_hw_gpio_free(struct ath_hw *ah, u32 gpio) 


	WARN_ON(gpio >= ah->caps.num_gpio_pins);



	if (ah->caps.gpio_requested & BIT(gpio)) {

		gpio_free(gpio);

	if (ah->caps.gpio_requested & BIT(gpio))

		ah->caps.gpio_requested &= ~BIT(gpio);

}

}

EXPORT_SYMBOL(ath9k_hw_gpio_free);



u32 ath9k_hw_gpio_get(struct ath_hw *ah, u32 gpio)