Commit 8ab3bf47 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Kalle Valo
Browse files

wifi: wlcore: sysfs: constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241216-sysfs-const-bin_attr-net-v1-3-ec460b91f274@weissschuh.net
parent aeda9245

drivers/net/wireless/ti/wlcore/sysfs.c

+2 −2
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ static ssize_t hw_pg_ver_show(struct device *dev, 
static DEVICE_ATTR_RO(hw_pg_ver);



static ssize_t wl1271_sysfs_read_fwlog(struct file *filp, struct kobject *kobj,

				       struct bin_attribute *bin_attr,

				       const struct bin_attribute *bin_attr,

				       char *buffer, loff_t pos, size_t count)

{

	struct device *dev = kobj_to_dev(kobj);
@@ -121,7 +121,7 @@ static ssize_t wl1271_sysfs_read_fwlog(struct file *filp, struct kobject *kobj, 


static const struct bin_attribute fwlog_attr = {

	.attr = { .name = "fwlog", .mode = 0400 },

	.read = wl1271_sysfs_read_fwlog,

	.read_new = wl1271_sysfs_read_fwlog,

};



int wlcore_sysfs_init(struct wl1271 *wl)