Commit 8abbf1f0 authored by Murad Masimov's avatar Murad Masimov Committed by Takashi Iwai
Browse files

ALSA: firewire-lib: fix return value on fail in amdtp_tscm_init() 



If amdtp_stream_init() fails in amdtp_tscm_init(), the latter returns zero,
though it's supposed to return error code, which is checked inside
init_stream() in file tascam-stream.c.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 47faeea2 ("ALSA: firewire-tascam: add data block processing layer")
Signed-off-by: default avatarMurad Masimov <m.masimov@maxima.ru>
Reviewed-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241101185517.1819-1-m.masimov@maxima.ru
parent c2d188e1

sound/firewire/tascam/amdtp-tascam.c

+1 −1
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ int amdtp_tscm_init(struct amdtp_stream *s, struct fw_unit *unit, 
	err = amdtp_stream_init(s, unit, dir, flags, fmt,

			process_ctx_payloads, sizeof(struct amdtp_tscm));

	if (err < 0)

		return 0;

		return err;



	if (dir == AMDTP_OUT_STREAM) {

		// Use fixed value for FDF field.