Commit 8ac6fcae authored by Chuck Lever's avatar Chuck Lever
Browse files

svcrdma: Unregister the device if svc_rdma_accept() fails 



To handle device removal, svc_rdma_accept() requests removal
notification for the underlying device when accepting a connection.
However svc_rdma_free() is not invoked if svc_rdma_accept() fails.
There needs to be a matching "unregister" in that case; otherwise
the device cannot be removed.

Fixes: c4de97f7 ("svcrdma: Handle device removal outside of the CM event handler")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarZhu Yanjun <yanjun.zhu@linux.dev>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent de08ffb7

net/sunrpc/xprtrdma/svc_rdma_transport.c

+1 −0
Original line number Diff line number Diff line
@@ -575,6 +575,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) 
	if (newxprt->sc_qp && !IS_ERR(newxprt->sc_qp))

		ib_destroy_qp(newxprt->sc_qp);

	rdma_destroy_id(newxprt->sc_cm_id);

	rpcrdma_rn_unregister(dev, &newxprt->sc_rn);

	/* This call to put will destroy the transport */

	svc_xprt_put(&newxprt->sc_xprt);

	return NULL;