Commit 8ad19469 authored by Thorsten Blum's avatar Thorsten Blum Committed by Greg Kroah-Hartman
Browse files

usbip: Use min to simplify stub_send_ret_submit 



Use min() to improve stub_send_ret_submit(). Change the local variable
'size' from 'int' to 'unsigned int' to prevent a signedness error and to
match the resulting type.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20251017091923.1694-2-thorsten.blum@linux.dev


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 071786e2

drivers/usb/usbip/stub_tx.c

+3 −6
Original line number Diff line number Diff line
@@ -4,6 +4,7 @@ 
 */



#include <linux/kthread.h>

#include <linux/minmax.h>

#include <linux/socket.h>

#include <linux/scatterlist.h>
@@ -239,17 +240,13 @@ static int stub_send_ret_submit(struct stub_device *sdev) 
		    urb->actual_length > 0) {

			if (urb->num_sgs) {

				unsigned int copy = urb->actual_length;

				int size;

				unsigned int size;



				for_each_sg(urb->sg, sg, urb->num_sgs, i) {

					if (copy == 0)

						break;



					if (copy < sg->length)

						size = copy;

					else

						size = sg->length;



					size = min(copy, sg->length);

					iov[iovnum].iov_base = sg_virt(sg);

					iov[iovnum].iov_len = size;