Commit 8ad2c72e authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Ard Biesheuvel
Browse files

efi/cper: Adjust infopfx size to accept an extra space 



Compiling with W=1 with werror enabled produces an error:

drivers/firmware/efi/cper-arm.c: In function ‘cper_print_proc_arm’:
drivers/firmware/efi/cper-arm.c:298:64: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
  298 |                         snprintf(infopfx, sizeof(infopfx), "%s ", newpfx);
      |                                                                ^
drivers/firmware/efi/cper-arm.c:298:25: note: ‘snprintf’ output between 2 and 65 bytes into a destination of size 64
  298 |                         snprintf(infopfx, sizeof(infopfx), "%s ", newpfx);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

As the logic there adds an space at the end of infopx buffer.
Add an extra space to avoid such warning.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent 05954511

drivers/firmware/efi/cper-arm.c

+1 −1
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ void cper_print_proc_arm(const char *pfx, 
	int i, len, max_ctx_type;

	struct cper_arm_err_info *err_info;

	struct cper_arm_ctx_info *ctx_info;

	char newpfx[64], infopfx[64];

	char newpfx[64], infopfx[ARRAY_SIZE(newpfx) + 1];



	printk("%sMIDR: 0x%016llx\n", pfx, proc->midr);